netdev - RE: [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <005601cf4194$752c0c60$5f842520$@samsung.com>
Date:	Sun, 16 Mar 2014 20:53:25 -0700
From:	Byungho An <bh74.an@...sung.com>
To:	'Francois Romieu' <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	davem@...emloft.net, ilho215.lee@...sung.com,
	siva.kallam@...sung.com, vipul.pandya@...sung.com,
	ks.giri@...sung.com, 'Joe Perches' <joe@...ches.com>
Subject: RE: [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung
 10Gb ethernet driver

Francois Romieu <romieu@...zoreil.com> :
> [...]
> > > > +struct sxgbe_core_ops {
> > > > +	/* MAC core initialization */
> > > > +	void (*core_init)(void __iomem *ioaddr);
> [...]
> > > > +	/* adjust SXGBE speed */
> > > > +	void (*set_speed)(void __iomem *ioaddr, unsigned char
speed); };
> > >
> > > This indirection level is never used.
> > Those are used, can you give more detail?
> 
> They are used but they always point to the same set of methods.
> Those methods could thus be directly called.
Yes, those methods can be called directly.
But I think it is acceptable for manageability and extension for future.

> 
> [...]
> > > > +/* SXGBE private data structures */ struct sxgbe_tx_queue {
> > > > +	u8 queue_no;
> > > > +	unsigned int irq_no;
> > > > +	struct sxgbe_priv_data *priv_ptr;
> > > > +	struct sxgbe_tx_norm_desc *dma_tx;
> > >
> > > You may lay things a bit differently.
> > can you give more detail?
> 
> Bigger fields first, u8 at the end. It will save padding in the struct.
OK.

> 
> --
> Ueimor
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the
body
> of a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html