netdev - RE: [net-next 03/16] i40evf: Support RSS option in ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Mar 2014 18:55:22 +0000
From:	"Williams, Mitch A" <mitch.a.williams@...el.com>
To:	Or Gerlitz <or.gerlitz@...il.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Sullivan, Catherine" <catherine.sullivan@...el.com>
Subject: RE: [net-next 03/16] i40evf: Support RSS option in ethtool


> -----Original Message-----
> From: Or Gerlitz [mailto:or.gerlitz@...il.com]
> Sent: Monday, March 17, 2014 7:40 AM
> To: Kirsher, Jeffrey T
> Cc: David Miller; Williams, Mitch A; netdev@...r.kernel.org;
> gospo@...hat.com; sassmann@...hat.com; Sullivan, Catherine
> Subject: Re: [net-next 03/16] i40evf: Support RSS option in ethtool
> 
> On Mon, Mar 17, 2014 at 2:45 PM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
> > From: Mitch Williams <mitch.a.williams@...el.com>
> >
> > Add support for viewing and modifying RSS hash options and RSS hash
> > look-up table programming through ethtool.
> [...]
> 
> FWIW, this commit does more... wouldn't it be worth dropping some
> words on that on that change-log?
> 

Well, Or, I'm not sure really what to say. I added code to change which hashing options RSS would use, and code to change the RSS lookup table.

Looks like Ben has some comments, so we'll have to respin this anyway. I'm happy to change the description, just wondering what you'd like to see here.

-Mitch

> [...]
> >  static struct ethtool_ops i40evf_ethtool_ops = {
> >         .get_settings           = i40evf_get_settings,
> >         .get_drvinfo            = i40evf_get_drvinfo,
> > @@ -378,6 +687,12 @@ static struct ethtool_ops i40evf_ethtool_ops = {
> >         .set_msglevel           = i40evf_set_msglevel,
> >         .get_coalesce           = i40evf_get_coalesce,
> >         .set_coalesce           = i40evf_set_coalesce,
> > +       .get_rxnfc              = i40evf_get_rxnfc,
> > +       .set_rxnfc              = i40evf_set_rxnfc,
> > +       .get_rxfh_indir_size    = i40evf_get_rxfh_indir_size,
> > +       .get_rxfh_indir         = i40evf_get_rxfh_indir,
> > +       .set_rxfh_indir         = i40evf_set_rxfh_indir,
> > +       .get_channels           = i40evf_get_channels,
> >  };
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html