netdev - Re: [net-next 03/16] i40evf: Support RSS option in ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZKpv-d-pPA6OuUMqcvZDa+ZM2rrLYBpOnaojfa6UYZLWg@mail.gmail.com>
Date:	Mon, 17 Mar 2014 23:19:25 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	"Williams, Mitch A" <mitch.a.williams@...el.com>
Cc:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Sullivan, Catherine" <catherine.sullivan@...el.com>
Subject: Re: [net-next 03/16] i40evf: Support RSS option in ethtool

On Mon, Mar 17, 2014 at 8:55 PM, Williams, Mitch A
<mitch.a.williams@...el.com> wrote:
>> On Mon, Mar 17, 2014 at 2:45 PM, Jeff Kirsher
>> <jeffrey.t.kirsher@...el.com> wrote:
>> > From: Mitch Williams <mitch.a.williams@...el.com>
>> >
>> > Add support for viewing and modifying RSS hash options and RSS hash
>> > look-up table programming through ethtool.
>> [...]
>>
>> FWIW, this commit does more... wouldn't it be worth dropping some
>> words on that on that change-log?
>>
>
> Well, Or, I'm not sure really what to say. I added code to change which hashing options RSS would use, and code to change the RSS lookup table.
>
> Looks like Ben has some comments, so we'll have to respin this anyway. I'm happy to change the description, just wondering what you'd like to see here.

When I made the comment I saw that you added bunch of ethtool calls
and wasn't sure this is covered in the change log, in 2nd look I see
one entry which isn't mentioned and isn't directly related to RSS, the
one that gets the number of channels, but it's minor and I assume can
stay here, maybe even non mentioned in the change log, but that will
be according to your taste


>
> -Mitch
>
>> [...]
>> >  static struct ethtool_ops i40evf_ethtool_ops = {
>> >         .get_settings           = i40evf_get_settings,
>> >         .get_drvinfo            = i40evf_get_drvinfo,
>> > @@ -378,6 +687,12 @@ static struct ethtool_ops i40evf_ethtool_ops = {
>> >         .set_msglevel           = i40evf_set_msglevel,
>> >         .get_coalesce           = i40evf_get_coalesce,
>> >         .set_coalesce           = i40evf_set_coalesce,
>> > +       .get_rxnfc              = i40evf_get_rxnfc,
>> > +       .set_rxnfc              = i40evf_set_rxnfc,
>> > +       .get_rxfh_indir_size    = i40evf_get_rxfh_indir_size,
>> > +       .get_rxfh_indir         = i40evf_get_rxfh_indir,
>> > +       .set_rxfh_indir         = i40evf_set_rxfh_indir,
>> > +       .get_channels           = i40evf_get_channels,
>> >  };
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html