netdev - Re: [PATCH net-next] gianfar: Fix P1010 config regression (SQ polling)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140320.160944.268619450160968028.davem@davemloft.net>
Date:	Thu, 20 Mar 2014 16:09:44 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	claudiu.manoil@...escale.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] gianfar: Fix P1010 config regression (SQ
 polling)

From: Claudiu Manoil <claudiu.manoil@...escale.com>
Date: Wed, 19 Mar 2014 15:39:39 +0200

> The P1010 device tree restricts the number of
> supported interrupt groups to 1, although the eth
> controller can support 2 interrupt groups and the
> driver assumes the Multi-Group mode ("fsl,etsec2" model).
> 
> So, in this case the assumption that the Multi-Group
> mode (MQ_MG_MODE) devices always support 2 interrupt
> groups is false.  To fix this, a check for the actual
> number of interrupt groups enabled in the board's
> device tree has been added in gfar_probe for the
> "fsl,etsec2" devices.
> 
> Without this fix, P1010 based boards claim support for
> 2 Tx queues to the net stack but only one is actually
> allocated, leading to NULL access in xmit.  This issue
> was introduced by enabling Single-Queue polling for
> the P1010 devices.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@...escale.com>

Please repost this, referencing the specific commit that introduced
the regression.  Either inline in the commit message, or using
the standard "Fixes: " tag right before your signoff.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html