netdev - Re: [PATCH net-next] atheros/atlx: use SET_ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140320.161705.764874095331082303.davem@davemloft.net>
Date:	Thu, 20 Mar 2014 16:17:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	wangweidong1@...wei.com
Cc:	jcliburn@...il.com, chris.snook@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] atheros/atlx: use SET_ETHTOOL_OPS directly

From: David Miller <davem@...emloft.net>
Date: Thu, 20 Mar 2014 16:07:01 -0400 (EDT)

> From: Wang Weidong <wangweidong1@...wei.com>
> Date: Wed, 19 Mar 2014 17:39:15 +0800
> 
>> As commit a6e28b34205b("staging/et131x: use SET_ETHTOOL_OPS
>> directly"), using a wrapper around SET_ETHTOOL_OPS macro is
>> not actually required, remove and use SET_ETHTOOL_OPS directly.
>> 
>> Signed-off-by: Wang Weidong <wangweidong1@...wei.com>
> 
> Applied, thank you.

I reverted, you did not ever build test this:

drivers/net/ethernet/atheros/atlx/atl2.c: In function ‘atl2_probe’:
drivers/net/ethernet/atheros/atlx/atl2.c:1398:2: error: ‘atl2_ethtool_ops’ undeclared (first use in this function)
drivers/net/ethernet/atheros/atlx/atl2.c:1398:2: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [drivers/net/ethernet/atheros/atlx/atl2.o] Error 1
make: *** [drivers/net/ethernet/atheros/atlx/atl2.o] Error 2

If you do not even have the time to do a test build, then I do not
have the time to review and apply your patches.