netdev - Re: [PATCHv5 net-next] VXLAN: fix nonfunctional neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140319.234332.1319239349442300687.davem@davemloft.net>
Date:	Wed, 19 Mar 2014 23:43:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dlstevens@...ibm.com
Cc:	amwang@...hat.com, netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [PATCHv5 net-next] VXLAN: fix nonfunctional neigh_reduce

From: David Stevens <dlstevens@...ibm.com>
Date: Wed, 19 Mar 2014 15:23:27 -0600

>>
>>> +	olen = 8; /* ND_OPT_TARGET_LL_ADDR */
>>
>>I guess this is what the variable declaration assignment was
>>meant to be used for.
> 
> There are 2 packets, neighbor solicitation (received) and
> neighbor advertisement (reply) and "olen" is initially the option length
> of the NA, a constant, for allocating its buffer. After that, the temporary
> variable "olen" is set to the variable length of the options in the
> received packet (NS) and used for processing its options.
> 
> So, it's an option length in both cases, but not the same
> value and not for the same packet, throughout.

That explains things, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html