netdev - Re: [PATCH net-next 2/4] net: use skb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395365878.9114.117.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 20 Mar 2014 18:37:58 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/4] net: use skb_get_hash in tx queue selection

On Thu, 2014-03-20 at 18:31 -0700, Eric Dumazet wrote:

> Wouldn't it be faster to simply set skb->hash in providers (TCP, UDP),
> to that we do not add this test here ?
> 
> After packet has been a while in a qdisc, access to skb->sk_hash will
> likely trigger a cache line miss.

I meant access to skb->sk->sk_hash will likely trigger a cache line
miss.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html