netdev - Re: [PATCH net-next] ixgbe: stop PTP before suspending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1395365797.2050.48.camel@jtkirshe-mobl>
Date:	Thu, 20 Mar 2014 18:36:37 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jakub Kicinski <kubakici@...pl>
Cc:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next] ixgbe: stop PTP before suspending

On Thu, 2014-03-20 at 20:14 +0100, Jakub Kicinski wrote:
> Resume path calls .open but suspend path cannot call .stop because
> fdirs should not be freed and control over hardware should not be
> released until WoL is configured.  To avoid having to duplicate all
> changes made in .stop on suspend path split out part of .stop that
> is relevant during suspend and call it from .stop and during suspend.
> 
> This fixes ixgbe_ptp_stop() not being called on suspend and helps
> to avoid similar bugs in the future.
> 
> Signed-off-by: Jakub Kicinski <kubakici@...pl>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 27
> ++++++++++++++-------------
>  1 file changed, 14 insertions(+), 13 deletions(-)

Thanks Jakub, I will add this to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)