netdev - RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Mar 2014 15:23:41 -0700
From:	Byungho An <bh74.an@...sung.com>
To:	'Vince Bridgers' <vbridgers2013@...il.com>
Cc:	netdev@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	devicetree@...r.kernel.org, 'David Miller' <davem@...emloft.net>,
	'GIRISH K S' <ks.giri@...sung.com>,
	'SIVAREDDY KALLAM' <siva.kallam@...sung.com>,
	'Vipul Chandrakant' <vipul.pandya@...sung.com>,
	'Ilho Lee' <ilho215.lee@...sung.com>,
	'Jay Bhat' <j.bhat@...sung.com>
Subject: RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb
 ethernet driver


Vince Bridgers <vbridgers2013@...il.com> :
> On Sat, Mar 22, 2014 at 1:23 AM, Byungho An <bh74.an@...sung.com> wrote:
> > From: Siva Reddy <siva.kallam@...sung.com>
> >
> > This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
> >

[snip]

> > +static int sxgbe_init_rx_buffers(struct net_device *dev,
> > +                                struct sxgbe_rx_norm_desc *p, int i,
> > +                                unsigned int dma_buf_sz,
> > +                                struct sxgbe_rx_queue *rx_ring)
> > +{
> > +       struct sxgbe_priv_data *priv = netdev_priv(dev);
> > +       struct sk_buff *skb;
> > +
> > +       skb = __netdev_alloc_skb(dev, dma_buf_sz, GFP_KERNEL);
> > +       if (!skb)
> > +               return -ENOMEM;
> > +
> > +       skb_reserve(skb, NET_IP_ALIGN);
> 
> Considering using netdev_alloc_skb_ip_align here as well. Looks like
> it was changed in refill, but not here
OK. Thanks

> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html