netdev - RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <008a01cf4624$997e1e20$cc7a5a60$@samsung.com>
Date:	Sat, 22 Mar 2014 16:15:18 -0700
From:	Byungho An <bh74.an@...sung.com>
To:	'Tomasz Figa' <tomasz.figa@...il.com>, netdev@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org
Cc:	'David Miller' <davem@...emloft.net>,
	'GIRISH K S' <ks.giri@...sung.com>,
	'SIVAREDDY KALLAM' <siva.kallam@...sung.com>,
	'Vipul Chandrakant' <vipul.pandya@...sung.com>,
	'Ilho Lee' <ilho215.lee@...sung.com>
Subject: RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb
 ethernet driver


Tomasz Figa <tomasz.figa@...il.com> :
> On 22.03.2014 22:55, Byungho An wrote:
> >
> > Tomasz Figa <tomasz.figa@...il.com> :
> 
> [snip]
> 
> >>> +	if (priv->irq <= 0) {
> >>> +		dev_err(dev, "sxgbe common irq parsing failed\n");
> >>> +		sxgbe_drv_remove(ndev);
> >>> +		return -EINVAL;
> >>> +	}
> >>> +
> >>> +	/* Get the TX/RX IRQ numbers */
> >>> +	for (i = 0, chan = 0; i < SXGBE_TX_QUEUES; i++) {
> >>> +		priv->txq[i]->irq_no = irq_of_parse_and_map(node, chan++);
> >>
> >> Hmm, this call looks suspicious. The "chan" variable starts here as 0
> >> and so
> > the
> >> first call to irq_of_parse_and_map() will end up with parsing the
> >> first
> > (zeroth)
> >> entry of "interrupts" property, which would be the same as returned
> >> by platform_get_irq(..., 0) above. Maybe this was the point where the
> "loop"
> >> variable should be used?
> > OK. it will be chan instead of loop.
> > thanks I missed.
> >
> >>
> >> Anyway, why you couldn't simply use platform_get_irq() here as well?
> > I'll change platform_get_irq to irq_of_parse_and_map because latter
> > can support PCI and nonPCI
> 
> Hmm, since this function is for probing only platform devices, I don't see
how
> this code could be used for PCI. For platform devices
> platform_get_irq() is preferred.
Those things will be added after this serise.

> 
> Best regards,
> Tomasz

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html