netdev - Re: [PATCH net-next 1/4] net: Rename rxhash to hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395698805.12610.78.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 24 Mar 2014 15:06:45 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/4] net: Rename rxhash to hash

On Thu, 2014-03-20 at 17:09 -0700, Tom Herbert wrote:
> The packet hash can be considered a property of the packet, not just
> on RX path.
> 
> This patch changes name of rxhash and l4_rxhash skbuff fields to be
> hash and l4_hash respectively. This includes changing uses of the
> field in the code which don't call the access functions.
> 
> Signed-off-by: Tom Herbert <therbert@...gle.com>
> ---
>  arch/s390/net/bpf_jit_comp.c |  8 ++++----
>  include/linux/skbuff.h       | 28 ++++++++++++++--------------
>  include/net/sock.h           |  4 ++--
>  include/trace/events/net.h   | 12 ++++++------
>  net/core/dev.c               | 11 ++++++-----
>  net/core/filter.c            |  2 +-
>  net/core/flow_dissector.c    | 10 +++++-----
>  net/packet/af_packet.c       |  2 +-
>  8 files changed, 39 insertions(+), 38 deletions(-)


It looks like you missed 

arch/arm/net/bpf_jit_32.c:			BUILD_BUG_ON(FIELD_SIZEOF(struct sk_buff, rxhash) != 4);
arch/arm/net/bpf_jit_32.c:			off = offsetof(struct sk_buff, rxhash);
arch/powerpc/net/bpf_jit_comp.c:			BUILD_BUG_ON(FIELD_SIZEOF(struct sk_buff, rxhash) != 4);
arch/powerpc/net/bpf_jit_comp.c:							  rxhash));
arch/sparc/net/bpf_jit_comp.c:				emit_skb_load32(rxhash, r_A);
arch/x86/net/bpf_jit_comp.c:				BUILD_BUG_ON(FIELD_SIZEOF(struct sk_buff, rxhash) != 4);
arch/x86/net/bpf_jit_comp.c:				if (is_imm8(offsetof(struct sk_buff, rxhash))) {
arch/x86/net/bpf_jit_comp.c:					EMIT3(0x8b, 0x47, offsetof(struct sk_buff, rxhash));
arch/x86/net/bpf_jit_comp.c:					EMIT(offsetof(struct sk_buff, rxhash), 4);


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html