netdev - Re: [PATCH net] net: vxlan: fix crash when interface is created with no group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF687EFECB.536163E6-ON87257CA7.00513C78-87257CA7.00513C81@us.ibm.com>
Date:	Wed, 26 Mar 2014 08:47:19 -0600
From:	David Stevens <dlstevens@...ibm.com>
To:	Mike Rapoport <mike.rapoport@...ellosystems.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Or Gerlitz <or.gerlitz@...il.com>
Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created with no
 group

Mike Rapoport <mike.rapoport@...ellosystems.com> wrote on 03/26/2014 05:47:54 AM:

> 
> It fixes the instant crashes occurring when vxlan interface goes up, but
> I have other crashes with custom vxlan configuration, e.g. in the
> following scenario:
> 
> Node A:
> $ ip link add vxlan1 type vxlan id 1 dev ethA
> $ ip addr add dev vxlan1 10.0.0.1/24
> $ ip link set up dev vxlan1
> $ bridge fdb append 00:00:00:00:00:00 dev vxlan1 dst <ethB IPv4 address>

I thought this MAC address would be an error, but I just noticed that you
submitted a patch adding interpretation of the all zeroes MAC address as
a default FDB.

That patch, IMO, should've either not gone in, or should've replaced (entirely)
the existing default_dst. I think the problems you are seeing are due to having
two "defaults".

Since the existing default_dst could be either a multicast group or a specific
destination, I don't understand the point of your patch:
    afbd8bae9c798c5cdbe4439d3a50536b5438247c

except possibly to support it as a list. In that case, at least that patch should've
removed default_dst and used the all-zeroes fdb entry instead, including group
joins and leaves when it is a multicast IP address.

I certainly don't see the point of having both.

                                                                      +-DLS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html