netdev - Re: [PATCH net-next v3] ipv6: do not overwrite inetpeer metrics prematurely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140326155606.GC27720@unicorn.suse.cz>
Date:	Wed, 26 Mar 2014 16:56:06 +0100
From:	Michal Kubecek <mkubecek@...e.cz>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net
Subject: Re: [PATCH net-next v3] ipv6: do not overwrite inetpeer metrics
 prematurely

On Wed, Mar 26, 2014 at 04:50:47PM +0100, Hannes Frederic Sowa wrote:
> On Wed, Mar 26, 2014 at 04:42:45PM +0100, Michal Kubecek wrote:
> > diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> > index fba54a4..b6dda6a 100644
> > --- a/net/ipv6/route.c
> > +++ b/net/ipv6/route.c
> > @@ -149,8 +149,10 @@ static u32 *ipv6_cow_metrics(struct dst_entry *dst, unsigned long old)
> >  		unsigned long prev, new;
> >  
> >  		p = peer->metrics;
> > -		if (inet_metrics_new(peer))
> > +		if (inet_metrics_new(peer) || (dst->flags | DST_KEEP_METRICS)) {
> >  			memcpy(p, old_p, sizeof(u32) * RTAX_MAX);
> > +			dst->flags &= ~DST_KEEP_METRICS;
> > +		}
> 
> The (dst->flags | DST_KEEP_METRICS) looks very suspicious. ;)

Oops. I already fixed this typo... and then did the submission from a
different branch. :-(

                                                       Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html