netdev - RE: [PATCH net-next 2/2] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Mar 2014 10:58:35 -0500
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'Yann Droneaud'" <ydroneaud@...eya.com>
Cc:	<netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<davem@...emloft.net>, <roland@...estorage.com>, <dm@...lsio.com>,
	<leedom@...lsio.com>, <santosh@...lsio.com>, <kumaras@...lsio.com>,
	<nirranjan@...lsio.com>, <hariprasad@...lsio.com>
Subject: RE: [PATCH net-next 2/2] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes



> > +		uresp.status_page_size = PAGE_SIZE;
> > +
> > +		spin_lock(&context->mmap_lock);
> > +		uresp.status_page_key = context->key;
> > +		context->key += PAGE_SIZE;
> > +		spin_unlock(&context->mmap_lock);
> > +
> 
> Is it really necessary to spinlock here since context is local to the
> function ?
> 

You're correct.

> 
> [...]
> 
> > diff --git a/drivers/infiniband/hw/cxgb4/user.h b/drivers/infiniband/hw/cxgb4/user.h
> > index 32b754c..11ccd27 100644
> > --- a/drivers/infiniband/hw/cxgb4/user.h
> > +++ b/drivers/infiniband/hw/cxgb4/user.h
> > @@ -70,4 +70,9 @@ struct c4iw_create_qp_resp {
> >  	__u32 qid_mask;
> >  	__u32 flags;
> >  };
> > +
> > +struct c4iw_alloc_ucontext_resp {
> > +	__u64 status_page_key;
> > +	__u32 status_page_size;
> > +};
> 
> If this is going to be part of the ABI, mind add an explicit padding to
> align the structure on 64bits.
> 

Sounds good.  Can you provide patches for these?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html