lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Mar 2014 13:52:18 +0100 From: Sander Eikelenboom <linux@...elenboom.it> To: Paul Durrant <paul.durrant@...rix.com> CC: xen-devel@...ts.xen.org, netdev@...r.kernel.org, Ian Campbell <ian.campbell@...rix.com>, Wei Liu <wei.liu2@...rix.com> Subject: Re: [PATCH net 1/3] xen-netback: remove pointless clause from if statement Thursday, March 27, 2014, 1:23:06 PM, you wrote: > This patch removes a test in start_new_rx_buffer() that checks whether > a copy operation is less than MAX_BUFFER_OFFSET in length, since > MAX_BUFFER_OFFSET is defined to be PAGE_SIZE and the only caller of > start_new_rx_buffer() already limits copy operations to PAGE_SIZE or less. > Signed-off-by: Paul Durrant <paul.durrant@...rix.com> > Cc: Ian Campbell <ian.campbell@...rix.com> > Cc: Wei Liu <wei.liu2@...rix.com> > Cc: Sander Eikelenboom <linux@...elenboom.it> > --- > drivers/net/xen-netback/netback.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c > index 438d0c0..befc413 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -192,8 +192,7 @@ static bool start_new_rx_buffer(int offset, unsigned long size, int head) > * into multiple copies tend to give large frags their > * own buffers as before. > */ > - if ((offset + size > MAX_BUFFER_OFFSET) && > - (size <= MAX_BUFFER_OFFSET) && offset && !head) > + if ((offset + size > MAX_BUFFER_OFFSET) && offset && !head) > return true; > > return false; Will put this through the test now .. -- Sander -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists