[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20140328.163639.788185926435545136.davem@davemloft.net>
Date: Fri, 28 Mar 2014 16:36:39 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: fbl@...hat.com
Cc: netdev@...r.kernel.org, dev@...nvswitch.com
Subject: Re: [PATCH net] openvswitch: fix a possible deadlock and lockdep
warning
From: Flavio Leitner <fbl@...hat.com>
Date: Thu, 27 Mar 2014 09:53:56 -0300
> There are two problematic situations.
>
> A deadlock can happen when is_percpu is false because it can get
> interrupted while holding the spinlock. Then it executes
> ovs_flow_stats_update() in softirq context which tries to get
> the same lock.
>
> The second sitation is that when is_percpu is true, the code
> correctly disables BH only for the local CPU, but that confuses
> lockdep enough to trigger the warning below.
>
> This patch disables BH for both cases fixing the real deadlock
> and the lockdep warning message.
...
> Signed-off-by: Flavio Leitner <fbl@...hat.com>
I'll let Jesse review and pick this up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists