netdev - Re: [PATCH net v2] openvswitch: fix a possible deadlock and lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140328.164242.318154109747795081.davem@davemloft.net>
Date:	Fri, 28 Mar 2014 16:42:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fbl@...hat.com
Cc:	netdev@...r.kernel.org, dev@...nvswitch.org
Subject: Re: [PATCH net v2] openvswitch: fix a possible deadlock and
 lockdep warning

From: Flavio Leitner <fbl@...hat.com>
Date: Thu, 27 Mar 2014 11:05:34 -0300

> There are two problematic situations.
> 
> A deadlock can happen when is_percpu is false because it can get
> interrupted while holding the spinlock. Then it executes
> ovs_flow_stats_update() in softirq context which tries to get
> the same lock.
> 
> The second sitation is that when is_percpu is true, the code
> correctly disables BH but only for the local CPU, so the
> following can happen when locking the remote CPU without
> disabling BH:
 ...
> Signed-off-by: Flavio Leitner <fbl@...hat.com>
> ---
>  v2: better commit message

Ok, I just saw Jesse's request that I apply this directly, so I
have done so.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html