netdev - Re: [PATCH net-next] tcp: generalize MAX_TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1396133246.21428.18.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Sat, 29 Mar 2014 15:47:26 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: generalize MAX_TCP_HEADER usage

On Sat, 2014-03-29 at 17:56 -0400, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Thu, 27 Mar 2014 13:19:06 -0700
> 
> > (Note that sk_stream_alloc_skb() uses MAX_TCP_HEADER anyway...)
> 
> But only after your changes.
> 
> Please make this clear in the commit message, I had to go check to see
> if there were in fact MAX_TCP_HEADER uses in sk_stream_alloc_skb in
> the current tree.

Yeah, lets leave sk_stream_alloc_skb() as it is (even it is only used by
TCP).

What I meant is that sk_stream_alloc_skb() uses MAX_TCP_HEADER (for
TCP), so tcp_xmit_size_goal() should not be picky.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html