netdev - Re: [PATCH 3/5] bonding: Initialize the ALB work queue for lb mode only.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 31 Mar 2014 15:00:18 -0700
From:	Mahesh Bandewar <maheshb@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Jay Vosburgh <j.vosburgh@...il.com>,
	Veaceslav Falico <vfalico@...hat.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Maciej Zenczykowski <maze@...gle.com>
Subject: Re: [PATCH 3/5] bonding: Initialize the ALB work queue for lb mode only.

On Mon, Mar 31, 2014 at 9:40 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Mon, 2014-03-31 at 09:27 -0700, Jay Vosburgh wrote:
>> Eric Dumazet <eric.dumazet@...il.com> wrote:
>>
>> >On Fri, 2014-03-28 at 22:29 -0700, Mahesh Bandewar wrote:
>> >> micro change to initialize / cancel the ALB work queue only
>> >> if the mode selected is ALB or TLB.
>> >>
>> >> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
>> >> ---
>> >
>> >Can the mode of a bonding device be dynamically changed ?
>>
>>       No.  The mode can only be changed when there are no slaves in
>> the bond, and the bond is administratively down.
>
> I don't see why this patch is needed.
>
> What about mii_work, arp_work ?
>
I was focusing on the lb mode only at this time.

> There is no cost calling INIT_DELAYED_WORK(&bond->alb_work,
> bond_alb_monitor) and cancel_delayed_work_sync(&bond->alb_work)
>
Why even bother initialize if we know *for sure* we are not going to
use it. In subsequent patch though the work queue may or may not be
needed based on the tlb_dynamic_mode selected. That's when I though we
should *only* enabled it in the mode that is relevant.

>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html