netdev - RE: [PATCH net-next] qlcnic: Fix build failure due to undefined reference to `vxlan_get_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <262CB373A6D1F14F9B81E82F74F77D5A46F88F20@avmb2.qlogic.org>
Date:	Mon, 31 Mar 2014 23:33:47 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev <netdev@...r.kernel.org>,
	Dept-HSG Linux NIC Dev <Dept-HSGLinuxNICDev@...gic.com>
Subject: RE: [PATCH net-next] qlcnic: Fix build failure due to undefined
 reference to `vxlan_get_rx_port'

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Tuesday, April 01, 2014 2:00 AM
> To: Shahed Shaikh
> Cc: netdev; Dept-HSG Linux NIC Dev
> Subject: Re: [PATCH net-next] qlcnic: Fix build failure due to undefined
> reference to `vxlan_get_rx_port'
> 
> From: Shahed Shaikh <shahed.shaikh@...gic.com>
> Date: Sun, 30 Mar 2014 10:42:25 -0400
> 
> > From: Shahed Shaikh <shahed.shaikh@...gic.com>
> >
> > Commit 2b3d7b758c687("qlcnic: Add VXLAN Rx offload support") uses
> > vxlan_get_rx_port() which caused build failure when VXLAN=m.
> >
> > This patch fixes the build failure by adding dependency on VXLAN in
> > Kconfig of qlcnic module and use vxlan_get_rx_port() accordingly.
> >
> > Signed-off-by: Shahed Shaikh <shahed.shaikh@...gic.com>
> > ---
> > Hi David,
> >
> > Please apply this patch to net-next.
> 
> Do this properly, don't just CPP protect the symbol that fails.
> 
> Look at how I40E_VXLAN is used, it protect everything from the
> ndo_*() ops to the surrounding support code.

Hi David,

Looks like net-next is closed. Please let me know if I can send the revised version of this patch as per your suggestion.

Thanks,
Shahed
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html