netdev - Re: [PATCH net-next] qlcnic: Fix build failure due to undefined reference to `vxlan_get_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140331.162950.1977000263135313417.davem@davemloft.net>
Date:	Mon, 31 Mar 2014 16:29:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	shahed.shaikh@...gic.com
Cc:	netdev@...r.kernel.org, Dept-HSGLinuxNICDev@...gic.com
Subject: Re: [PATCH net-next] qlcnic: Fix build failure due to undefined
 reference to `vxlan_get_rx_port'

From: Shahed Shaikh <shahed.shaikh@...gic.com>
Date: Sun, 30 Mar 2014 10:42:25 -0400

> From: Shahed Shaikh <shahed.shaikh@...gic.com>
> 
> Commit 2b3d7b758c687("qlcnic: Add VXLAN Rx offload support") uses
> vxlan_get_rx_port() which caused build failure when VXLAN=m.
> 
> This patch fixes the build failure by adding dependency on VXLAN
> in Kconfig of qlcnic module and use vxlan_get_rx_port() accordingly.
> 
> Signed-off-by: Shahed Shaikh <shahed.shaikh@...gic.com>
> ---
> Hi David,
> 
> Please apply this patch to net-next.

Do this properly, don't just CPP protect the symbol that fails.

Look at how I40E_VXLAN is used, it protect everything from the
ndo_*() ops to the surrounding support code.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html