netdev - Re: [PATCH net-next] net/mlx4_core: Handle null return by pci_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140331.163240.1147956381197703417.davem@davemloft.net>
Date:	Mon, 31 Mar 2014 16:32:40 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	weiyang@...ux.vnet.ibm.com
Cc:	or.gerlitz@...il.com, amirv@...lanox.com, netdev@...r.kernel.org,
	yevgenyp@...lanox.com, bhelgaas@...gle.com
Subject: Re: [PATCH net-next] net/mlx4_core: Handle null return by
 pci_match_id()

From: Wei Yang <weiyang@...ux.vnet.ibm.com>
Date: Mon, 31 Mar 2014 11:54:39 +0800

> On Sun, Mar 30, 2014 at 09:08:06PM +0300, Or Gerlitz wrote:
>>On Sun, Mar 30, 2014 at 6:26 PM, Amir Vadai <amirv@...lanox.com> wrote:
>>> Fix issue introduced by commit: 97a5221 "net/mlx4_core: pass
>>> pci_device_id.driver_data to __mlx4_init_one during reset".
>>>
>>> pci_match_id() might return NULL if someone binds the driver to a device
>>> manually using /sys/bus/pci/drivers/.../new_id. Need to check 'id'
>>> before using it.
>>>
>>> Thanks to Bjorn who raised the problem.
>>
>>Well, that commit was applied to net and is now present in Linus
>>tree... so assuming it's too late for 3.14, need to queue this for
>>-stable
>>
>>Or.
> 
> Sorry for this bothering, hope this will not block someone.
> 
> Here is my suggestion for fixing this, not sure this is a good way to export
> pci_match_device() to modules. This is my current solution to this problem. If
> you have any comments, please let me know.

This needs to be ACK'd by the PCI maintainers, please make sure they see this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html