netdev - Re: [PATCH net-next] net-gro: restore frag0 optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396300784.29410.75.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 31 Mar 2014 14:19:44 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	mschmidt@...hat.com, netdev@...r.kernel.org, edumazet@...gle.com,
	hkchu@...gle.com
Subject: Re: [PATCH net-next] net-gro: restore frag0 optimization

On Mon, 2014-03-31 at 14:01 -0700, Eric Dumazet wrote:

> 
> BTW, I found a off-by-one error in skb_gro_header_hard()


>  
> -static inline int skb_gro_header_hard(struct sk_buff *skb, unsigned int hlen)
> +static inline bool skb_gro_header_hard(const struct sk_buff *skb,
> +				       unsigned int hlen)
>  {
> -	return NAPI_GRO_CB(skb)->frag0_len < hlen;
> +	return NAPI_GRO_CB(skb)->frag0_len <= hlen;
>  }


Oh well, scratch this. This strange function name fooled me again.

bool slowpath = hlen > NAPI_GRO_CB(skb)->frag0_len;



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html