netdev - Re: [PATCH net-next] net-gro: restore frag0 optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <533AEBEB.5020400@redhat.com>
Date:	Tue, 01 Apr 2014 18:40:11 +0200
From:	Michal Schmidt <mschmidt@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jerry Chu <hkchu@...gle.com>
Subject: Re: [PATCH net-next] net-gro: restore frag0 optimization

On 03/30/2014 06:28 AM, Eric Dumazet wrote:
> Main difference between napi_frags_skb() and napi_gro_receive() is that
> the later is called while ethernet header was already pulled by the NIC
> driver (eth_type_trans() was called before napi_gro_receive())
> 
> Jerry Chu in commit 299603e8370a ("net-gro: Prepare GRO stack for the
> upcoming tunneling support") tried to remove this difference by calling
> eth_type_trans() from napi_frags_skb() instead of doing this later from
> napi_frags_finish()
> 
> Goal was that napi_gro_complete() could call 
> ptype->callbacks.gro_complete(skb, 0)  (offset of first network header =
> 0)
> 
> Also, xxx_gro_receive() handlers all use off = skb_gro_offset(skb) to
> point to their own header, for the current skb and ones held in gro_list
> 
> Problem is this cleanup work defeated the frag0 optimization:
> It turns out the consecutive pskb_may_pull() calls are too expensive.
> 
> This patch brings back the frag0 stuff in napi_frags_skb().
> 
> As all skb have their mac header in skb head, we no longer need
> skb_gro_mac_header()

Eric,
thank you. The patch improves the performance. Though it's still not as
fast as it was before the commit "net-gro: Prepare GRO stack for the
upcoming tunneling support". In repeated netperf runs my reporter now
sees occasional results above 9 Gb/s, but on average it's only 7 Gb/s.

With your patch only Ethernet headers (and not other headers) are copied
into skbs' heads, but this is done for all skbs. Previously (before
Jerry's patch) no copying was needed for skbs that were GRO_MERGED.
Is this correct?

Regards,
Michal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html