netdev - Re: [PATCH net] net: vxlan: fix crash when interface is created with no group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7OO9Cc-vVzeQ4dozj1HyBgU9pHZL-aJL9KxYKx+SVaLVA@mail.gmail.com>
Date:	Tue, 1 Apr 2014 12:22:12 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Mike Rapoport <mike.rapoport@...ellosystems.com>
Cc:	David Miller <davem@...emloft.net>,
	David Stevens <dlstevens@...ibm.com>,
	netdev <netdev@...r.kernel.org>, stable@...r.kernel.org
Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created with
 no group

On Mon, Mar 31, 2014 at 11:23 PM, Mike Rapoport
<mike.rapoport@...ellosystems.com> wrote:
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 1236812..d091e52 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -871,6 +871,9 @@ static int vxlan_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
>         if (err)
>                 return err;
>
> +       if (vxlan->default_dst.remote_ip.sa.sa_family != ip.sa.sa_family)
> +               return -EAFNOSUPPORT;
> +

Or move this check into vxlan_fdb_parse() so that vxlan_fdb_delete()
could also catch this error?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html