netdev - Re: [net-next 01/13] e1000e: Fix no connectivity when driver loaded with cable out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1404011807080.14882@ionos.tec.linutronix.de>
Date:	Tue, 1 Apr 2014 18:07:35 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Fabio Estevam <festevam@...il.com>
cc:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	David Ertman <davidx.m.ertman@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 01/13] e1000e: Fix no connectivity when driver loaded
 with cable out

On Tue, 1 Apr 2014, Fabio Estevam wrote:

> On Mon, Mar 31, 2014 at 8:34 PM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
> > From: David Ertman <davidx.m.ertman@...el.com>
> >
> > In commit da1e2046e5, the flow for enabling/disabling an Si errata
> > workaround (e1000_lv_jumbo_workaround_ich8lan) was changed to fix a problem
> > with iAMT connections dropping on interface down with jumbo frames set.
> > Part of this change was to move the function call disabling the workaround
> > to e1000e_down() from the e1000_setup_rctl() function.  The mechanic for
> > disabling of this workaround involves writing several MAC and PHY registers
> > back to hardware defaults.
> >
> > After this commit, when the driver is loaded with the cable out, the PHY
> > registers are not programmed with the correct default values.  This causes
> > the device to be capable of transmitting packets, but is unable to recieve
> > them until this workaround is called.
> >
> > The flow of e1000e's open code relies upon calling the above workaround to
> > expicitly program these registers either with jumbo frame appropriate settings
> > or h/w defaults on 82579 and newer hardware.
> >
> > Fix this issue by adding logic to e1000_setup_rctl() that not only calls
> > e1000_lv_jumbo_workaround_ich8lan() when jumbo frames are set, to enable the
> > workaround, but also calls this function to explicitly disable the workaround
> > in the case that jumbo frames are not set.
> >
> > Signed-off-by: Dave Ertman <davidx.m.ertman@...el.com>
> > Tested-by: Jeff Pieper <jeffrey.e.pieper@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Maybe a Reported-by tag from Thomas is missing?

Plus a Tested-by: me :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html