netdev - Re: [PATCH v5 net-next 0/2] patchset: Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Apr 2014 12:20:16 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	VenkatKumar.Duvvuru@...lex.Com
Cc:	ben@...adent.org.uk, netdev@...r.kernel.org
Subject: Re: [PATCH v5 net-next 0/2] patchset: Support for configurable RSS
 hash key

From: Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
Date: Tue, 1 Apr 2014 15:19:48 +0000

>> > By grouping the key and hash together, with some reserved fields
>> > (which the setter should initially require to be equal to zero), it
>> > should be possible to fill in support for numbered RSS contexts later
>> > without yet another new structure and operations.
> 
> 
>> If that is the case, why don't we add from the start a "u32 rss_context;"
>> field that has to be set to zero for now?
> 
> The current structure has got three u32 reserved fields already. We could use one of them when the support is added.

Just do as I said, naming one of those to "rss_context" now, and require
that it be zero.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html