netdev - Re: [PATCH] vlan: unnecessary to check if vlan_pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396558866.12330.18.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 03 Apr 2014 14:01:06 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	roy.qing.li@...il.com, netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH] vlan: unnecessary to check if vlan_pcpu_stats is NULL

On Thu, 2014-04-03 at 16:36 -0400, David Miller wrote:
> From: roy.qing.li@...il.com
> Date: Thu,  3 Apr 2014 20:45:25 +0800
> 
> > From: Li RongQing <roy.qing.li@...il.com>
> > 
> > if allocating memory for vlan_pcpu_stats failed, the device can not be operated
> > 
> > Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> 
> This check seems to have been there since Eric Dumazet added precise
> RX statistic accounting.
> 
> It looks unnecessary to me, Eric?

Right, this patch seems fine, thanks !

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html