netdev - Re: [PATCH] vlan: unnecessary to check if vlan_pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140403.163603.2057792710871114160.davem@davemloft.net>
Date:	Thu, 03 Apr 2014 16:36:03 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH] vlan: unnecessary to check if vlan_pcpu_stats is NULL

From: roy.qing.li@...il.com
Date: Thu,  3 Apr 2014 20:45:25 +0800

> From: Li RongQing <roy.qing.li@...il.com>
> 
> if allocating memory for vlan_pcpu_stats failed, the device can not be operated
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

This check seems to have been there since Eric Dumazet added precise
RX statistic accounting.

It looks unnecessary to me, Eric?

 ...
>  static struct rtnl_link_stats64 *vlan_dev_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
>  {
> +	struct vlan_pcpu_stats *p;
> +	u32 rx_errors = 0, tx_dropped = 0;
> +	int i;
>  
> -	if (vlan_dev_priv(dev)->vlan_pcpu_stats) {
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html