netdev - Re: [PATCH net] net-gro: reset skb->truesize in napi_reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140403.161834.1232262926542795326.davem@davemloft.net>
Date:	Thu, 03 Apr 2014 16:18:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] net-gro: reset skb->truesize in napi_reuse_skb()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 03 Apr 2014 09:28:10 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Recycling skb always had been very tough...
> 
> This time it appears GRO layer can accumulate skb->truesize
> adjustments made by drivers when they attach a fragment to skb.
> 
> skb_gro_receive() can only subtract from skb->truesize the used part
> of a fragment.
> 
> I spotted this problem seeing TcpExtPruneCalled and
> TcpExtTCPRcvCollapsed that were unexpected with a recent kernel, where
> TCP receive window should be sized properly to accept traffic coming
> from a driver not overshooting skb->truesize.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Nasty...

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html