netdev - Re: [PATCH net] net-gro: reset skb->truesize in napi_reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHA+R7MZEHhqLrxdcp-M3pWEC_wVkm5W5v8HUDSc_w10HYg5aQ@mail.gmail.com>
Date:	Fri, 16 May 2014 14:27:00 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	David Miller <davem@...emloft.net>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net-gro: reset skb->truesize in napi_reuse_skb()

On Thu, Apr 3, 2014 at 1:18 PM, David Miller <davem@...emloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Thu, 03 Apr 2014 09:28:10 -0700
>
>> From: Eric Dumazet <edumazet@...gle.com>
>>
>> Recycling skb always had been very tough...
>>
>> This time it appears GRO layer can accumulate skb->truesize
>> adjustments made by drivers when they attach a fragment to skb.
>>
>> skb_gro_receive() can only subtract from skb->truesize the used part
>> of a fragment.
>>
>> I spotted this problem seeing TcpExtPruneCalled and
>> TcpExtTCPRcvCollapsed that were unexpected with a recent kernel, where
>> TCP receive window should be sized properly to accept traffic coming
>> from a driver not overshooting skb->truesize.
>>
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>
> Nasty...
>
> Applied, thanks Eric.

I think this patch should be queued for -stable as well?
Looking at your stable queue [1], it's not there. :)

Thanks!

1. http://patchwork.ozlabs.org/bundle/davem/stable/?state=*
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html