lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 07 Apr 2014 13:15:12 -0400 (EDT)
From:	David Miller <>
Subject: Re: [PATCH next-next 5/6] net: Call skb_checksum_init in IPv6

From: Tom Herbert <>
Date: Fri, 4 Apr 2014 17:28:09 -0700 (PDT)

> @@ -62,6 +62,14 @@ __sum16 csum_ipv6_magic(const struct in6_addr *saddr,
>  EXPORT_SYMBOL(csum_ipv6_magic);
>  #endif
> +__wsum ip6_pseudo_compute(struct sk_buff *skb, int proto)
> +{
> +	return ~csum_unfold(csum_ipv6_magic(&ipv6_hdr(skb)->saddr,
> +					    &ipv6_hdr(skb)->daddr,
> +					    skb->len, proto, 0));
> +}
> +EXPORT_SYMBOL(ip6_pseudo_compute);

Similarly to the ipv4 case this should really be inline.

I see what the problem is, you've made this now a callback so now it
can't be really inlined any more.

That's really a terrible negative to this set of changes, please see
if you can avoid that and inline all of this exactly how it is done
now in the input paths.

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists