netdev - Re: [PATCH next-next 5/6] net: Call skb_checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+mtBx8ezm2CEbRefqZ_0bUz6APmz-ha_f_PkuN4_R_mX73gPA@mail.gmail.com>
Date:	Mon, 7 Apr 2014 13:46:46 -0700
From:	Tom Herbert <therbert@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH next-next 5/6] net: Call skb_checksum_init in IPv6

On Mon, Apr 7, 2014 at 10:15 AM, David Miller <davem@...emloft.net> wrote:
> From: Tom Herbert <therbert@...gle.com>
> Date: Fri, 4 Apr 2014 17:28:09 -0700 (PDT)
>
>> @@ -62,6 +62,14 @@ __sum16 csum_ipv6_magic(const struct in6_addr *saddr,
>>  EXPORT_SYMBOL(csum_ipv6_magic);
>>  #endif
>>
>> +__wsum ip6_pseudo_compute(struct sk_buff *skb, int proto)
>> +{
>> +     return ~csum_unfold(csum_ipv6_magic(&ipv6_hdr(skb)->saddr,
>> +                                         &ipv6_hdr(skb)->daddr,
>> +                                         skb->len, proto, 0));
>> +}
>> +EXPORT_SYMBOL(ip6_pseudo_compute);
>
> Similarly to the ipv4 case this should really be inline.
>
> I see what the problem is, you've made this now a callback so now it
> can't be really inlined any more.
>
> That's really a terrible negative to this set of changes, please see
> if you can avoid that and inline all of this exactly how it is done
> now in the input paths.
>
Okay, but it's going to be hard to do without resorting to macro's I think...

> Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html