netdev - Re: [Patch net] ipv4: fib: check forwarding before checking send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140408.172343.917107273854891906.davem@davemloft.net>
Date:	Tue, 08 Apr 2014 17:23:43 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, ebiederm@...ssion.com, ja@....bg,
	cwang@...pensource.com
Subject: Re: [Patch net] ipv4: fib: check forwarding before checking
 send_redirects

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue, 8 Apr 2014 14:17:08 -0700

> We are not supposed even to execute __fib_validate_source() in such
> case, are we? :)

Yes, we used to, every time we'd make a routing cache entry, we'd
execute this code.

Check fib_validate_source() from before the routing cache removal if
you don't believe me.

That check you are editing was added by myself as an optimization
that was necessary after the routing cache removal since this
function performs two FIB table lookups every time it is called.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html