netdev - [PATCH v2] net phylib: Remove unnecessary condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <534413E1.8070205@gmail.com>
Date:	Tue, 08 Apr 2014 20:51:05 +0530
From:	Balakumaran Kannan <kumaran.4353@...il.com>
To:	f.fainelli@...il.com, netdev@...r.kernel.org
Subject: [PATCH v2] net phylib: Remove unnecessary condition check

This condition check makes no difference in the code flow since 3.10

Signed-off-by: Balakumaran Kannan <kumaran.4353@...il.com>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

---
 drivers/net/phy/phy.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1d788f1..1b6d09a 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -756,12 +756,8 @@ void phy_state_machine(struct work_struct *work)
			netif_carrier_on(phydev->attached_dev);
			phydev->adjust_link(phydev->attached_dev);

-		} else if (0 == phydev->link_timeout--) {
+		} else if (0 == phydev->link_timeout--)
			needs_aneg = 1;
-			/* If we have the magic_aneg bit, we try again */
-			if (phydev->drv->flags & PHY_HAS_MAGICANEG)
-				break;
-		}
		break;
	case PHY_NOLINK:
		err = phy_read_status(phydev);
-- 1.7.9.5 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html