netdev - Re: [PATCH v2] net phylib: Remove unnecessary condition check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140408.130345.2291211656267642777.davem@davemloft.net>
Date:	Tue, 08 Apr 2014 13:03:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kumaran.4353@...il.com
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net phylib: Remove unnecessary condition check

From: Balakumaran Kannan <kumaran.4353@...il.com>
Date: Tue, 08 Apr 2014 20:51:05 +0530

> This condition check makes no difference in the code flow since 3.10
> 
> Signed-off-by: Balakumaran Kannan <kumaran.4353@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Your patch is still being corrupted by your email client.

> -			/* If we have the magic_aneg bit, we try again */
> -			if (phydev->drv->flags & PHY_HAS_MAGICANEG)
> -				break;
> -		}
> 		break;

On that break; line there should be a space then TAB characters in the patch,
instead there are only TAB characters.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html