netdev - Re: [PATCH] staging: r8723au: Fix build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1397060145.14321.21.camel@joe-AO722>
Date:	Wed, 09 Apr 2014 09:15:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	gregkh@...uxfoundation.org, netdev@...r.kernel.org,
	devel@...verdev.osuosl.org, Jes Sorensen <Jes.Sorensen@...hat.com>,
	kbuild-all@...org
Subject: Re: [PATCH] staging: r8723au: Fix build warnings

On Wed, 2014-04-09 at 10:05 -0500, Larry Finger wrote:
> The kbuild test robot reports the following:
[]
> diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h b/drivers/staging/rtl8723au/include/rtw_mlme.h
[]
> -void rtw_set_roaming(struct rtw_adapter *adapter, u8 to_roaming);
> -u8 rtw_to_roaming(struct rtw_adapter *adapter);
> +inline void rtw_set_roaming(struct rtw_adapter *adapter, u8 to_roaming);
> +inline u8 rtw_to_roaming(struct rtw_adapter *adapter);

I think this doesn't make sense.

Either the inline should be removed from
the .c file or the function should be moved
into the .h file and made static inline.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html