lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 09 Apr 2014 20:07:06 +0200 From: Jes Sorensen <Jes.Sorensen@...hat.com> To: Larry Finger <Larry.Finger@...inger.net> Cc: gregkh@...uxfoundation.org, netdev@...r.kernel.org, devel@...verdev.osuosl.org, kbuild-all@...org Subject: Re: [PATCH V2] staging: r8723au: Fix build warnings Larry Finger <Larry.Finger@...inger.net> writes: > The kbuild test robot reports the following: > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 75ff24fa52f0cc512ceee4c377632b91a3a80811 > commit: 9176303c404741b2f96796466437f2badf6e289b staging: r8723au: > Turn on build of new driver > date: 4 days ago > config: make ARCH=avr32 allyesconfig > > All warnings: > >>> drivers/staging/rtl8723au/include/rtw_mlme.h:620: warning: >>> rtw_set_roaming' declared inline after being called > drivers/staging/rtl8723au/include/rtw_mlme.h:620: warning: previous > declaration of 'rtw_set_roaming' was here >>> drivers/staging/rtl8723au/include/rtw_mlme.h:621: warning: >>> rtw_to_roaming' declared inline after being called > drivers/staging/rtl8723au/include/rtw_mlme.h:621: warning: previous > declaration of 'rtw_to_roaming' was here > -- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c: In function > Hal_EEValueCheck': >>> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2277: warning: >>> comparison is always true due to limited range of data type > > The first two warnings are fixed by making the two prototypes be "inline" to match > the actual routine. The third warning comes from testing that a u8 quantity is positive. > > Reported-by: kbuild test robot <fengguang.wu@...el.com> > Signed-off-by: Larry Finger <Larry.Finger@...inger.net> > Cc: Jes Sorensen <Jes.Sorensen@...hat.com> > Cc: kbuild-all@...org Acked-by: Jes Sorensen <Jes.Sorensen@...hat.com> Looks good to me! Jes -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists