netdev - Re: [PATCH v2.56] datapath: Add basic MPLS support to kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140409233326.GA18623@verge.net.au>
Date:	Thu, 10 Apr 2014 08:33:28 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	dev@...nvswitch.org, netdev@...r.kernel.org,
	Jesse Gross <jesse@...ira.com>,
	Pravin B Shelar <pshelar@...ira.com>
Cc:	Ben Pfaff <blp@...ira.com>, Ravi K <rkerur@...il.com>,
	Joe Stringer <joe@...d.net.nz>
Subject: Re: [PATCH v2.56] datapath: Add basic MPLS support to kernel

On Tue, Apr 01, 2014 at 12:46:20PM +0900, Simon Horman wrote:
> Hi Jesse, Hi Pravin, Hi All,
> 
> This patchset makes use of a whitelist to only allow mpls_push actions to
> be applied to packets with an ethertype where the tag order is well defined
> and implemented. This avoids the problem of where an MPLS LSE should be
> added in relation to a VLAN or similar tag.
> 
> The list of allowed ethertypes is currently:
> 
>   - ETH_P_IP (0x0800)
>   - ETH_P_ARP (0x0806)
>   - ETH_P_RARP (0x0835)
>   - ETH_P_IPV6 (0x86DD)
>   - ETH_P_MPLS_UC (0x8847)
>   - ETH_P_MPLS_MC (0x8847)

Hi,

a gentle nudge on this one.
I'd be most appreciative of some feedback.

> I have updated this patch since v2.55 so that:
> 
> * The MPLS ethertypes are included in the whitelist of ethertypes
>   that allow mpls_push actions.
> * It once again applies on top of the master branch
> 
> 
> Simon Horman (1):
>   datapath: Add basic MPLS support to kernel
> 
>  OPENFLOW-1.1+                                   |   4 -
>  datapath/Modules.mk                             |   1 +
>  datapath/actions.c                              | 119 +++++++++-
>  datapath/datapath.c                             |   4 +-
>  datapath/flow.c                                 |  29 +++
>  datapath/flow.h                                 |  17 +-
>  datapath/flow_netlink.c                         | 298 ++++++++++++++++++++++--
>  datapath/flow_netlink.h                         |   2 +-
>  datapath/linux/compat/gso.c                     |  70 +++++-
>  datapath/linux/compat/gso.h                     |  41 +++-
>  datapath/linux/compat/include/linux/netdevice.h |   6 +-
>  datapath/linux/compat/netdevice.c               |  10 +-
>  datapath/mpls.h                                 |  15 ++
>  include/linux/openvswitch.h                     |   9 +-
>  14 files changed, 568 insertions(+), 57 deletions(-)
>  create mode 100644 datapath/mpls.h
> 
> -- 
> 1.8.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html