netdev - Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140424085729.CBE6671E58@kuma.localdomain>
Date:	Thu, 24 Apr 2014 17:57:29 +0900 (JST)
From:	yamamoto@...inux.co.jp (YAMAMOTO Takashi)
To:	horms@...ge.net.au
Cc:	dev@...nvswitch.org, netdev@...r.kernel.org, jesse@...ira.com,
	pshelar@...ira.com, rkerur@...il.com
Subject: Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to
 kernel

hi,

> + * Due to the sample action there may be multiple possible eth types.
> + * In order to correctly validate actions all possible types are tracked
> + * and verified. This is done using struct eth_types.

is there any real-world use cases of these actions inside a sample?
otherwise, how about just rejecting such combinations?
it doesn't seem to worth the code complexity to me.
(sorry if it has been already discussed.  it's the first time for me
to seriously read this long-lived patch.)

YAMAMOTO Takashi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html