lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 15 Apr 2014 11:57:41 +0000
From:	Sathya Perla <Sathya.Perla@...lex.Com>
To:	"Li, ZhenHua" <>
CC:	Subramanian Seetharaman <>,
	Ajit Khaparde <Ajit.Khaparde@...lex.Com>,
	"" <>,
	"" <>
Subject: RE: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet

> -----Original Message-----
> From: Li, ZhenHua []
> Because netif_running() is called in netif_device_detach and
> netif_device_attach. To avoid dev status changed while
> netif_device_detach/attach is not finished, I think a rtnl_lock and
> unlock should be called to avoid this.

Ok. I'd like to then factor the code slightly differently by using
routines like this:

be_close_sync() {

   	if (netif_running(netdev))


and similarly for be_open_sync()

And, I'd need some time to test these flows too.
Would you be OK with this?

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists