netdev - Re: [PATCH net] ipv4: add a sock pointer to ip_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140415.131636.1847117096992048895.davem@davemloft.net>
Date:	Tue, 15 Apr 2014 13:16:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	nasa4836@...il.com, jchapman@...alix.com, netdev@...r.kernel.org,
	lucien.xin@...il.com
Subject: Re: [PATCH net] ipv4: add a sock pointer to ip_queue_xmit() and
 friends

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 15 Apr 2014 07:33:12 -0700

> diff --git a/net/core/dst.c b/net/core/dst.c
> index ca4231ec7347..7443c2725c9c 100644
> --- a/net/core/dst.c
> +++ b/net/core/dst.c
> @@ -142,12 +142,12 @@ loop:
>  	mutex_unlock(&dst_gc_mutex);
>  }
>  
> -int dst_discard(struct sk_buff *skb)
> +int dst_discard_sk(struct sock *sk, struct sk_buff *skb)
>  {
>  	kfree_skb(skb);
>  	return 0;
>  }
> -EXPORT_SYMBOL(dst_discard);
> +EXPORT_SYMBOL(dst_discard_sk);
>  
>  const u32 dst_default_metrics[RTAX_MAX + 1] = {
>  	/* This initializer is needed to force linker to place this variable

This doesn't compile, I'd expect to see hunks such as:

@@ -184,7 +184,7 @@ void *dst_alloc(struct dst_ops *ops, struct net_device *dev,
 	dst->xfrm = NULL;
 #endif
 	dst->input = dst_discard;
-	dst->output = dst_discard;
+	dst->output = dst_discard_sk;
 	dst->error = 0;
 	dst->obsolete = initial_obsolete;
 	dst->header_len = 0;

for this file, but I don't.  Maybe you posted an outdated revision of your
patch?  There also aren't the necessary decnet and XFRM changes, layers
which also use dst->output().

Anyways, I'm splitting up your patches and sorting this out.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html