netdev - Re: [PATCH net] ipv4: add a sock pointer to ip_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1397592364.4222.101.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 15 Apr 2014 13:06:04 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	nasa4836@...il.com, jchapman@...alix.com, netdev@...r.kernel.org,
	lucien.xin@...il.com
Subject: Re: [PATCH net] ipv4: add a sock pointer to ip_queue_xmit() and
 friends

On Tue, 2014-04-15 at 13:16 -0400, David Miller wrote:

> This doesn't compile, I'd expect to see hunks such as:
> 
> @@ -184,7 +184,7 @@ void *dst_alloc(struct dst_ops *ops, struct net_device *dev,
>  	dst->xfrm = NULL;
>  #endif
>  	dst->input = dst_discard;
> -	dst->output = dst_discard;
> +	dst->output = dst_discard_sk;
>  	dst->error = 0;
>  	dst->obsolete = initial_obsolete;
>  	dst->header_len = 0;
> 
> for this file, but I don't.  Maybe you posted an outdated revision of your
> patch?  There also aren't the necessary decnet and XFRM changes, layers
> which also use dst->output().
> 
> Anyways, I'm splitting up your patches and sorting this out.

Hmmpff. The truth is I did a "make allyesconfig;make -j24", and the
build completed, but I missed warnings.

And the thing even booted and ran properly.

Sorry for this, and thanks for taking care of the mess.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html