netdev - Re: [PATCH net-next RESEND 1/2] net: phy: export genphy_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcbwRod-YSXKJ1hgd81SaPHkB7mEMWFZbEa1yaBUU-134A@mail.gmail.com>
Date:	Wed, 16 Apr 2014 12:14:03 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Daniel Mack <zonque@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	mugunthanvnm <mugunthanvnm@...com>, ujhelyi.m@...il.com
Subject: Re: [PATCH net-next RESEND 1/2] net: phy: export genphy_config_init()

2014-04-16 8:19 GMT-07:00 Daniel Mack <zonque@...il.com>:
> This enables other drivers to call this generic implementation, and then
> only do specific details on top of it.
>
> Signed-off-by: Daniel Mack <zonque@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> ---
> Resending this after 3.15-rc1 has been released, assuming that the
> net-next tree is now open again.
>
>  drivers/net/phy/phy_device.c | 3 ++-
>  include/linux/phy.h          | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 2f6989b..84485ea 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
> @@ -1029,7 +1029,7 @@ static int gen10g_read_status(struct phy_device *phydev)
>         return 0;
>  }
>
> -static int genphy_config_init(struct phy_device *phydev)
> +int genphy_config_init(struct phy_device *phydev)
>  {
>         int val;
>         u32 features;
> @@ -1074,6 +1074,7 @@ static int genphy_config_init(struct phy_device *phydev)
>
>         return 0;
>  }
> +EXPORT_SYMBOL(genphy_config_init);
>
>  static int gen10g_config_init(struct phy_device *phydev)
>  {
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index 565188c..dcf7f13 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -609,6 +609,7 @@ static inline int phy_read_status(struct phy_device *phydev)
>         return phydev->drv->read_status(phydev);
>  }
>
> +int genphy_config_init(struct phy_device *phydev);
>  int genphy_setup_forced(struct phy_device *phydev);
>  int genphy_restart_aneg(struct phy_device *phydev);
>  int genphy_config_aneg(struct phy_device *phydev);
> --
> 1.9.0
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html