netdev - Re: [PATCH net-next RESEND 2/2] net: phy: at803x: use genphy_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Apr 2014 12:14:15 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Daniel Mack <zonque@...il.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	mugunthanvnm <mugunthanvnm@...com>, ujhelyi.m@...il.com
Subject: Re: [PATCH net-next RESEND 2/2] net: phy: at803x: use genphy_config_init()

2014-04-16 8:19 GMT-07:00 Daniel Mack <zonque@...il.com>:
> Use the generic bits from genphy_config_init() instead of implementing
> the same functionality again.
>
> Signed-off-by: Daniel Mack <zonque@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> ---
> Resending this after 3.15-rc1 has been released, assuming that the
> net-next tree is now open again.
>
>  drivers/net/phy/at803x.c | 36 +++---------------------------------
>  1 file changed, 3 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index bc71947..850171f 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -141,41 +141,11 @@ static int at803x_resume(struct phy_device *phydev)
>
>  static int at803x_config_init(struct phy_device *phydev)
>  {
> -       int val;
>         int ret;
> -       u32 features;
> -
> -       features = SUPPORTED_TP | SUPPORTED_MII | SUPPORTED_AUI |
> -                  SUPPORTED_FIBRE | SUPPORTED_BNC;
> -
> -       val = phy_read(phydev, MII_BMSR);
> -       if (val < 0)
> -               return val;
> -
> -       if (val & BMSR_ANEGCAPABLE)
> -               features |= SUPPORTED_Autoneg;
> -       if (val & BMSR_100FULL)
> -               features |= SUPPORTED_100baseT_Full;
> -       if (val & BMSR_100HALF)
> -               features |= SUPPORTED_100baseT_Half;
> -       if (val & BMSR_10FULL)
> -               features |= SUPPORTED_10baseT_Full;
> -       if (val & BMSR_10HALF)
> -               features |= SUPPORTED_10baseT_Half;
> -
> -       if (val & BMSR_ESTATEN) {
> -               val = phy_read(phydev, MII_ESTATUS);
> -               if (val < 0)
> -                       return val;
> -
> -               if (val & ESTATUS_1000_TFULL)
> -                       features |= SUPPORTED_1000baseT_Full;
> -               if (val & ESTATUS_1000_THALF)
> -                       features |= SUPPORTED_1000baseT_Half;
> -       }
>
> -       phydev->supported = features;
> -       phydev->advertising = features;
> +       ret = genphy_config_init(phydev);
> +       if (ret < 0)
> +               return ret;
>
>         if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) {
>                 ret = phy_write(phydev, AT803X_DEBUG_ADDR,
> --
> 1.9.0
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html