netdev - Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140421112601.GC3200@hercules>
Date:	Mon, 21 Apr 2014 12:26:01 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	David Miller <davem@...emloft.net>
Cc:	zoltan.kiss@...rix.com, jesse@...ira.com, pshelar@...ira.com,
	tgraf@...hat.com, dev@...nvswitch.org, pablo@...filter.org,
	kadlec@...ckhole.kfki.hu, edumazet@...gle.com, dborkman@...hat.com,
	therbert@...gle.com, jasowang@...hat.com, fw@...len.de,
	joe@...ches.com, horms@...ge.net.au, jiri@...nulli.us,
	mst@...hat.com, Paul.Durrant@...rix.com, JBeulich@...e.com,
	herbert@...dor.apana.org.au, mszeredi@...e.cz,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in
 skb_zerocopy and handle errors

Hi David,

On Thu, Mar 27, 2014 at 03:29:56PM -0400, David Miller wrote:
> From: Zoltan Kiss <zoltan.kiss@...rix.com>
> Date: Wed, 26 Mar 2014 22:37:45 +0000
> 
> > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> > orphan them. Also, it doesn't handle errors, so this patch takes care of that
> > as well, and modify the callers accordingly. skb_tx_error() is also added to
> > the callers so they will signal the failed delivery towards the creator of the
> > skb.
> > 
> > Signed-off-by: Zoltan Kiss <zoltan.kiss@...rix.com>
> 
> Fingers crossed :-)  Applied, thanks Zoltan.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Could you please queue this for stable as well?  It has CVE-2014-2568
assigned to it and I believe it is applicable to some of the trees.

Cheers,
--
Luís
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html