netdev - Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398181118.3624.203.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 22 Apr 2014 16:38:38 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Luis Henriques <luis.henriques@...onical.com>
Cc:	David Miller <davem@...emloft.net>, zoltan.kiss@...rix.com,
	jesse@...ira.com, pshelar@...ira.com, tgraf@...hat.com,
	dev@...nvswitch.org, pablo@...filter.org, kadlec@...ckhole.kfki.hu,
	edumazet@...gle.com, dborkman@...hat.com, therbert@...gle.com,
	jasowang@...hat.com, fw@...len.de, joe@...ches.com,
	horms@...ge.net.au, jiri@...nulli.us, mst@...hat.com,
	Paul.Durrant@...rix.com, JBeulich@...e.com,
	herbert@...dor.apana.org.au, mszeredi@...e.cz,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in
 skb_zerocopy and handle errors

On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques wrote:
> Hi David,
> 
> On Thu, Mar 27, 2014 at 03:29:56PM -0400, David Miller wrote:
> > From: Zoltan Kiss <zoltan.kiss@...rix.com>
> > Date: Wed, 26 Mar 2014 22:37:45 +0000
> > 
> > > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> > > orphan them. Also, it doesn't handle errors, so this patch takes care of that
> > > as well, and modify the callers accordingly. skb_tx_error() is also added to
> > > the callers so they will signal the failed delivery towards the creator of the
> > > skb.
> > > 
> > > Signed-off-by: Zoltan Kiss <zoltan.kiss@...rix.com>
> > 
> > Fingers crossed :-)  Applied, thanks Zoltan.
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> Could you please queue this for stable as well?  It has CVE-2014-2568
> assigned to it and I believe it is applicable to some of the trees.

It was applied to 3.13, but needs backporting to earlier versions.  I
posted my attempt in
<1397429860.10849.86.camel@...deye.wl.decadent.org.uk> but it needs
testing/reviewing.

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)