netdev - Re: [PATCH][net-next] tcp: remove the duplicate prefixes in the logging message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJFZqHxg9YSmHWb9DgmdtO01vVz3vN86DaCNdswRtZviemh3mQ@mail.gmail.com>
Date:	Wed, 23 Apr 2014 21:32:43 +0800
From:	Li RongQing <roy.qing.li@...il.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	netdev <netdev@...r.kernel.org>, joe@...ches.com
Subject: Re: [PATCH][net-next] tcp: remove the duplicate prefixes in the
 logging message

On Wed, Apr 23, 2014 at 5:35 PM, Daniel Borkmann <dborkman@...hat.com> wrote:
> On 04/23/2014 11:28 AM, roy.qing.li@...il.com wrote:
>>
>> From: Li RongQing <roy.qing.li@...il.com>
>>
>> The current message is:
>>         TCP: TCP: Possible SYN flooding on port 80. Sending cookies. ...
>>
>> The cause is that pr_info will implicitly print the pr_fmt string, which
>> is standard
>> prefix, and explicitly print the "proto" which is "TCP:" too
>>
>> it is unsuitable to not print proto, since proto maybe TCPv6, so use
>> printk directly.
>
>
> Can't you just leave the pr_info() instead, and reword that into something
> like:
>
>   "Possible %s SYN flooding[...]", proto
To ipv4:

TCP: Possible TCP SYN flooding on port 80. Sending cookies. ...

To ipv6:

TCP: Possible TCPv6 SYN flooding on port 80. Sending cookies. ...


I think there are two "TCP" still, and it is  duplicate;


-Roy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html