netdev - Re: [PATCH 3.13] core, nfqueue, openvswitch: Orphan frags in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA4pPG9yVO1C1JnkxV3mSdAqh3QB44Y8xsVRvQv5PHM-Ag@mail.gmail.com>
Date:	Wed, 23 Apr 2014 09:31:25 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Zoltan Kiss <zoltan.kiss@...rix.com>,
	Luis Henriques <luis.henriques@...onical.com>,
	David Miller <davem@...emloft.net>, jesse@...ira.com,
	pshelar@...ira.com, Thomas Graf <tgraf@...hat.com>,
	dev@...nvswitch.org, pablo@...filter.org, kadlec@...ckhole.kfki.hu,
	edumazet@...gle.com, Daniel Borkmann <dborkman@...hat.com>,
	Tom Herbert <therbert@...gle.com>, jasowang@...hat.com,
	fw@...len.de, Joe Perches <joe@...ches.com>, horms@...ge.net.au,
	jiri@...nulli.us, mst@...hat.com, Paul.Durrant@...rix.com,
	Jan Beulich <JBeulich@...e.com>,
	Herbert Xu <herbert@...dor.apana.org.au>, mszeredi@...e.cz,
	netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org,
	xen-devel@...ts.xenproject.org, netdev <netdev@...r.kernel.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH 3.13] core, nfqueue, openvswitch: Orphan frags in
 skb_zerocopy and handle errors

On Tue, Apr 22, 2014 at 3:18 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
> From: Zoltan Kiss <zoltan.kiss@...rix.com>
>
> commit 36d5fe6a000790f56039afe26834265db0a3ad4c upstream.
>
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well, and modify the callers accordingly. skb_tx_error() is also added to
> the callers so they will signal the failed delivery towards the creator of the
> skb.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@...rix.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> [bwh: Backported to 3.13: skb_zerocopy() is new in 3.14, but was moved from a
>  static function in nfnetlink_queue.  We need to patch that and its caller, but
>  not openvswitch.]
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

Deja-vu.  I sent almost the same patch to netdev a while ago and you
acked it there.  So I guess I'll ack your copy as well :).  Not sure
why either version wasn't picked up by Dave.

josh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html