netdev - Re: xfrm: Can "struct netlbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29136798.pGbRqWE1nJ@sifl>
Date:	Thu, 24 Apr 2014 10:40:37 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:	casey@...aufler-ca.com, netdev@...r.kernel.org,
	linux-security-module@...r.kernel.org
Subject: Re: xfrm: Can "struct netlbl_audit" be killed?

On Thursday, April 24, 2014 11:29:08 PM Tetsuo Handa wrote:
> Paul Moore wrote:
> > On Thursday, April 24, 2014 08:51:35 PM Tetsuo Handa wrote:
> > > Hello, Casey and Paul.
> > > 
> > > At the ipsec-next tree,
> > > 
> > >   /* Audit Information */
> > >   struct xfrm_audit {
> > >   
> > >   	u32     secid;
> > >   	kuid_t  loginuid;
> > >   	unsigned int sessionid;
> > >   
> > >   };
> > > 
> > > has just been killed
> > > (
> > > https://git.kernel.org/cgit/linux/kernel/git/klassert/ipsec-next.git/com
> > > mit
> > > /?id=f1370cc4a01e61007ab3020c761cef6b88ae3729 and
> > > https://git.kernel.org/cgit/linux/kernel/git/klassert/ipsec-next.git/com
> > > mit
> > > /?id=2e71029e2c32ecd59a2e8f351517bfbbad42ac11 ) because these arguments
> > > are
> > > always calculated from current thread's security context.
> > 
> > Before we go to far, is it always true for AF_KEY that "current" is set to
> > the sending process?  If the answer is no, I think we have a problem.
> 
> Speak of "struct xfrm_audit", I think the answer is yes, or commit ab5f5e8b
> "[XFRM]: xfrm audit calls" is wrong.

I'm not assuming that ab5f5e8b is correct.  It would be nice to know for sure 
that current is always equal to the sending process for AF_KEY, and that isn't 
something I'm certain is true off the top of my head.

-- 
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html